Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource leak in InputStreamDownload.java #1070

Open
siddjain opened this issue May 21, 2016 · 1 comment
Open

Resource leak in InputStreamDownload.java #1070

siddjain opened this issue May 21, 2016 · 1 comment

Comments

@siddjain
Copy link

There is a bug in this code:

@Override
    public void write(HttpServletResponse response) throws IOException {
        writeDetails(response);

        OutputStream out = response.getOutputStream();
        ByteStreams.copy(stream, out);  
    }

the input stream is never disposed.
I have submitted a PR:
#1069

@Turini
Copy link
Member

Turini commented May 23, 2016

thanks @siddjain. I just left a comment in your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants