Skip to content

Commit 6618248

Browse files
committed
fix: remove unused savings state and callback
1 parent 0f21277 commit 6618248

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

frontend/src/components/SavingsCard.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,20 @@ import { Input } from "./ui/Input";
66
import { ProgressBar } from "./ui/ProgressBar";
77

88
interface SavingsCardProps {
9-
onSavingsChange?: (savings: number) => void;
109
remaining: number;
1110
onAnalyzeClick?: () => void;
1211
}
1312

14-
export function SavingsCard({ onSavingsChange, remaining, onAnalyzeClick }: SavingsCardProps) {
13+
export function SavingsCard({ remaining, onAnalyzeClick }: SavingsCardProps) {
1514
const [savings, setSavings] = useState<number>(0);
1615
const [isEditing, setIsEditing] = useState(false);
1716
const [editValue, setEditValue] = useState("");
1817

1918
useEffect(() => {
2019
api.savings.get().then((res) => {
2120
setSavings(res.savings);
22-
onSavingsChange?.(res.savings);
2321
});
24-
}, [onSavingsChange]);
22+
}, []);
2523

2624
const startEdit = () => {
2725
setEditValue(savings.toString());
@@ -38,7 +36,6 @@ export function SavingsCard({ onSavingsChange, remaining, onAnalyzeClick }: Savi
3836
if (isNaN(value)) return;
3937
await api.savings.update(value);
4038
setSavings(value);
41-
onSavingsChange?.(value);
4239
setIsEditing(false);
4340
};
4441

frontend/src/pages/Dashboard.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useState, useCallback } from "react";
1+
import { useState } from "react";
22
import { Layout } from "../components/Layout";
33
import { MonthNav } from "../components/MonthNav";
44
import { Summary } from "../components/Summary";
@@ -18,7 +18,6 @@ interface DashboardProps {
1818
}
1919

2020
export function Dashboard({ onSettingsClick }: DashboardProps) {
21-
const [savings, setSavings] = useState(0);
2221
const [showVarianceModal, setShowVarianceModal] = useState(false);
2322
const {
2423
summary,
@@ -32,10 +31,6 @@ export function Dashboard({ onSettingsClick }: DashboardProps) {
3231
downloadPdf,
3332
} = useMonth();
3433

35-
const handleSavingsChange = useCallback((value: number) => {
36-
setSavings(value);
37-
}, []);
38-
3934
if (loading && !summary) {
4035
return (
4136
<Layout onSettingsClick={onSettingsClick}>
@@ -71,7 +66,6 @@ export function Dashboard({ onSettingsClick }: DashboardProps) {
7166
<div className="flex flex-col sm:flex-row items-stretch sm:items-center justify-between gap-4">
7267
<div className="w-full sm:w-80">
7368
<SavingsCard
74-
onSavingsChange={handleSavingsChange}
7569
remaining={summary.remaining}
7670
onAnalyzeClick={() => setShowVarianceModal(true)}
7771
/>

0 commit comments

Comments
 (0)