Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extension problem #57

Closed
noembryo opened this issue Dec 3, 2024 · 4 comments
Closed

File extension problem #57

noembryo opened this issue Dec 3, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@noembryo
Copy link

noembryo commented Dec 3, 2024

These are the app's specs (it would be nice if copying these, produced a markdown text too.. just saying 😃 )
Windows 10 22H2

{
    "applicationName": "Markdown Viewer",
    "applicationDescription": "Standalone Markdown Viewer",
    "applicationVersion": "3.1.1",
    "homepage": "https://github.com/c3er/mdview",
    "issueLink": "https://github.com/c3er/mdview/issues",
    "frameworkVersions": [
        [
            "electron",
            "30.0.3"
        ],
        [
            "chrome",
            "124.0.6367.119"
        ],
        [
            "node",
            "20.11.1"
        ],
        [
            "v8",
            "12.4.254.15-electron.0"
        ]
    ]
}

The application opens the files that have an extension of .MD as simple texts.
Just renaming the extension fixes this, but I don't see the point in this, since Windows filenames are not case sensitive..

Anyway, thank you for this nice app.. 🙏

@github-actions github-actions bot added the needs reaction Owner didn't react to this issue yet label Dec 3, 2024
@c3er
Copy link
Owner

c3er commented Dec 3, 2024

Thank you for filing this issue!

The application opens the files that have an extension of .MD as simple texts.
Just renaming the extension fixes this, but I don't see the point in this, since Windows filenames are not case sensitive..

You're right that Windows doesn't make a difference but strings in (virtually) any programming language are case sensitive if no extra step was made. But you're right, that it doesn't make sense to distinguish between .md and .MD (in any OS). I'll release a fixed version hopefully soon.

Until then, there is another workaround: in the settings dialog is a checkbox "Render files of this type as Markdown"

Screenshot of settings dialog

You can reach the settings dialog via "Edit" --> "Settings" or be pressing Ctrl+, (Control + comma).

These are the app's specs (it would be nice if copying these, produced a markdown text too.. just saying 😃 )

Please make another issue, if you really wish this 🙂

Anyway, thank you for this nice app.. 🙏

You're welcome! Thank you!

@c3er c3er added bug Something isn't working and removed needs reaction Owner didn't react to this issue yet labels Dec 3, 2024
@noembryo
Copy link
Author

noembryo commented Dec 3, 2024

These are the app's specs (it would be nice if copying these, produced a markdown text too.. just saying 😃 )

Please make another issue, if you really wish this 🙂

Nah, it's not something that I really need very often (hopefully 😉).
It's just something that I would do if I wanted for my programs to report their info to the world.
Fortunately, for now, I just let the users send me error logs, so a simple text is enough for that..

Anyway, I'll close that now since it will be fixed in a future update..
🙏

@noembryo noembryo closed this as completed Dec 3, 2024
@c3er
Copy link
Owner

c3er commented Dec 3, 2024

These are the app's specs (it would be nice if copying these, produced a markdown text too.. just saying 😃 )

Please make another issue, if you really wish this 🙂

Nah, it's not something that I really need very often (hopefully 😉). It's just something that I would do if I wanted for my programs to report their info to the world. Fortunately, for now, I just let the users send me error logs, so a simple text is enough for that..

This was just an easy implementation this way, this info is mostly for me and I have no problem reading JSON.

Anyway, I'll close that now since it will be fixed in a future update..
🙏

I'm reopening this. Issues should stay open until I released a fixed version. I'll close this together with a notification about the new version when it is released.

@c3er c3er reopened this Dec 3, 2024
@github-actions github-actions bot added the needs reaction Owner didn't react to this issue yet label Dec 3, 2024
@c3er c3er removed the needs reaction Owner didn't react to this issue yet label Dec 3, 2024
c3er added a commit that referenced this issue Dec 18, 2024
This fixes issue #57

It seems necessary to introduce a version to the application settings.
The file extensions for Markdown files were case sensitive before.
@c3er
Copy link
Owner

c3er commented Dec 18, 2024

I released version 3.2.0 which compares the file extensions now case insensitive.

@c3er c3er closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants