Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application does not render this table. #48

Open
ElektroStudios opened this issue Feb 9, 2024 · 3 comments
Open

Application does not render this table. #48

ElektroStudios opened this issue Feb 9, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ElektroStudios
Copy link

ElektroStudios commented Feb 9, 2024

I don't know why, but the application is not rendering this table:

|Included:|Excluded:|
|:--|:--|
|Released Games|Cancelled or Not yet released Games
|[Compilations](https://gamefaqs.gamespot.com/cpc/category/233-miscellaneous-compilation)|


Maybe the parser fails to recognize the table due the blank white spaces at the start of each line?. I don't know if that could be the issue, but I can say that table renders fine with web-based things like when using the typical web-extensions in the web-browser to read markdown files, or when using other stand-alone applications like Markdown Monster or Sublime Text (Markdown​Live​Preview plugin), and in this GitHub comment:

  • The following table of platform exclusive games was generated programmatically by scraping content from Gamefaqs website:

    Included: Excluded:
    Released Games Cancelled or Not yet released Games
    Compilations

I attach the original markdown file here:

@github-actions github-actions bot added the needs reaction Owner didn't react to this issue yet label Feb 9, 2024
@c3er
Copy link
Owner

c3er commented Feb 9, 2024

Thanks for filing this issue!

I could reproduce this bug and interestingly, the table renders just fine, if the table is not indented or indented just the right way, i.e. it starts at the same column as the text of the last bullet point.

Screenshot of different table indentations and their renderings

I attached a file with all variants: table-tests.md

I'll take a look as soon as I have time and energy.

It could be that the bug originates from a dependency of the Markdown renderer, e.g. markdown-it-multimd-table. If this is the case, I'll create a bug report at the appropriate project and hope the best.

And, while there is a workaround available (IMO), it is clearly a bug of my tool, because other renderers don't have this problem.

@c3er c3er added bug Something isn't working and removed needs reaction Owner didn't react to this issue yet labels Feb 9, 2024
@c3er
Copy link
Owner

c3er commented Apr 16, 2024

It is actually an issue with dependencies.

I created an issue in markdown-it for one case. The other case is caused by markdown-it-multimd-table and there exists already an issue for exactly this case.

I'll concentrate now on the zoom issue.

c3er added a commit that referenced this issue May 4, 2024
@c3er c3er added the help wanted Extra attention is needed label Jul 7, 2024
@c3er
Copy link
Owner

c3er commented Jul 7, 2024

I added a ""help wanted" tag:

  1. This issue originates from the dependencies markdown-it and markdown-it-multimd-table. Maybe, there will be someone, who has experience with markdown-it and is interested to fix it.
  2. I want to concentrate on the major restructuring to tackle some other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants