-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Connector] Change path_list
option setting using concating string with comma ,
to string list for FtpConnector
#424
Comments
This issue maybe good for beginner. |
@Jake-00 Thanks for your issue, you suggestion is we just not support directories right, we can use file path directly? |
@hk-lrzy To read directories already support, but to read multiple specified files do not support yet. |
I see, can you use same parameter to support? like we check the path is file or directory, if directory we support to list it and if it is file we support read it directly. I don't want to add parameter because user need to know use which one, it's not necessary for user. |
Sounds more reasonable, shall I change the issue description? |
Sure~ |
When diving deeper in |
path_list
option setting using concating string with comma ,
to string list for FtpConnector
Description
For
FtpConnector
, currently we can specify directories to read by setting configuration json file using optionpath_list
, but it can't specify several files' path to read.Suggetion:
path_list
specify a string contains path list, it is better to change to specify a string list like belowFtpCoinnector
BitSail Component or Code Module
BitSail Connector
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: