javy compile should use javy_quickjs_provider_v2
#766
Labels
bug
Something isn't working
Comments
saulecabrera
added a commit
to saulecabrera/javy
that referenced
this issue
Oct 4, 2024
Closes bytecodealliance#766 This commit ensures that the soon-to-be-deprecated `compile` command makes use of the right (v2) provider for compilation. Not ensuring this has the potential to cause issues upon a new release of QuickJS containing bytecode incompatibilities.
saulecabrera
added a commit
that referenced
this issue
Oct 7, 2024
* Use the v2 provider for `compile` Closes #766 This commit ensures that the soon-to-be-deprecated `compile` command makes use of the right (v2) provider for compilation. Not ensuring this has the potential to cause issues upon a new release of QuickJS containing bytecode incompatibilities. * Rename param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're in the process of deprecating the CLI's
compilecommand in favor of thebuildcommand, for more details see: #702.As such, the
compilecommand is considered to be frozen and is only guaranteed to be compatible with thejavy_quickjs_provider_v2provider module, therefore thecompileshould use thev2provider instead of the latest available one. This not causing any issues at the moment, but it could cause potential issues in case a new version is released in which incompatible QuickJS bytecode is emitted.The proposed solution is to use the v2 provider, available in-tree when the
compilecommand is invoked.The text was updated successfully, but these errors were encountered: