Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted import error: 'findDOMNode' is not exported from 'react-dom' (imported as 'findDOMNode'). #1858

Open
cas8180 opened this issue Dec 7, 2024 · 9 comments

Comments

@cas8180
Copy link

cas8180 commented Dec 7, 2024

It appears that Virtualized Table is not compatible with React 19. The findDOMNode was deprecated in 19. So any of us that are using Next 15 or regular React 19 are not hit with the following errors:

⚠ ./node_modules/react-virtualized/dist/es/Table/Table.js
Attempted import error: 'findDOMNode' is not exported from 'react-dom' (imported as 'findDOMNode').

To reproduce.
Simply try to use these components in React 19.

@michaeljaltamirano
Copy link

michaeljaltamirano commented Dec 9, 2024

Two attempted PR fixes in #1855 and #1856

@bvaughn Please let us know if either of the above options is suitable, or if you recommend migrating to react-window (or other options, including a fork of the library, e.g. https://github.com/remerge/react-virtualized) for compatibility! 🙏

@KevinVandy
Copy link

+1. TanStack Virtual looks like it is going to have to be our alternative to migrate to, although it doesn't have quite as good performance.

@JohnnyTheTank
Copy link

+1

@mikalai-sauchanka
Copy link

+1 (findDOMNode was removed in React 19).

@mpmua
Copy link

mpmua commented Dec 25, 2024

+1

@cas8180
Copy link
Author

cas8180 commented Dec 30, 2024

It blows my mind that this package is used by over 93k people and there are 187 contributors and nobody can just merge in the fix that someone else was kind enough to do to fix this thing. I believe using this package also breaks the hot reload feature within Next.js 15 which kills DX.

@honia19
Copy link

honia19 commented Dec 31, 2024

+1

1 similar comment
@Amitabh1989
Copy link

+1

@adubrouski
Copy link

I published a fork of react-virtualized with support for React 19 and types.

https://github.com/adubrouski/react-virtualized-compat
https://www.npmjs.com/package/react-virtualized-compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants