Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary buttons, not just the subscribe/upgrade ones #3446

Closed
Tracked by #2574
mary-ext opened this issue Sep 13, 2024 · 2 comments
Closed
Tracked by #2574

Arbitrary buttons, not just the subscribe/upgrade ones #3446

mary-ext opened this issue Sep 13, 2024 · 2 comments
Assignees
Labels

Comments

@mary-ext
Copy link

No description provided.

@mary-ext mary-ext self-assigned this Sep 13, 2024
@mary-ext
Copy link
Author

mary-ext commented Sep 13, 2024

@jmduke should we convert subscribe and upgrade buttons to a single customizable button? in the UI we could still offer the options to insert either buttons, it'd be wired to insert a predefined URL. It'll impact our styling though (noticed that subscribe button has a different style going on esp. in the web archive)

@jmduke
Copy link
Member

jmduke commented Sep 13, 2024

Yup, I think that totally makes sense. and IIRC the subscribe button is just flatly better in the archive than the other one, so if we can standardize on that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants