Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading version from workspace version doesn't work #122

Open
FredrikNoren opened this issue Sep 28, 2022 · 5 comments
Open

Reading version from workspace version doesn't work #122

FredrikNoren opened this issue Sep 28, 2022 · 5 comments

Comments

@FredrikNoren
Copy link

I'm getting the following error: map, expected a string for key 'package.version', when I tried switching to workspace versioning: https://twitter.com/m_ou_se/status/1572991230404956162

@ogoffart
Copy link

Note that this seems fixed in the git version.

(Perhaps it is time for a release?)

ogoffart added a commit to slint-ui/slint that referenced this issue Sep 27, 2023
cargo-bundle used to bundle the lsp on macOs doesn't support workspace
fields. (burtonageo/cargo-bundle#122)

Revert to explicit keys in this file for the one needed by cargo-bundle
@TrueFiskibility
Copy link

Thanks for the tip @ogoffart! I installed the latest development version with this command:

cargo install cargo-bundle --git https://github.com/burtonageo/cargo-bundle.git --rev 60cf179180008d97427051d3a6496e2183d92a05

Workspace inheritance seems to work with this development version.

@metasim
Copy link

metasim commented Jul 10, 2024

@ogoffart Any plans for a point release? Love the tool!

@ogoffart
Copy link

(I'm not related to this repository.)

@metasim
Copy link

metasim commented Jul 12, 2024

(I'm not related to this repository.)

Oops. Sorry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants