Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] False Positive with pgrep in start.sh Script #1475

Open
2 tasks done
xabru opened this issue Sep 14, 2024 · 1 comment
Open
2 tasks done

[BUG] False Positive with pgrep in start.sh Script #1475

xabru opened this issue Sep 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@xabru
Copy link

xabru commented Sep 14, 2024

What happened?

The start.sh script uses pgrep to find the PID of nginx to determine its status. Unfortunately, pgrep sometimes detects nginx processes running on virtual machines or different operating systems, leading to incorrect assumptions about nginx's status on the target system.

How to reproduce?

# On a system where nginx is correctly running
./usr/share/bunkerweb/scripts/start.sh start
pgrep nginx
# Output: PID(s) of nginx if running on the target system

# On a different OS, running a separate nginx instance
pgrep nginx
# Output: PID(s) of nginx from a different OS, not relevant to our target system

Configuration file(s) (yaml or .env)

No response

Relevant log output

No response

BunkerWeb version

1.5.9

What integration are you using?

Docker

Linux distribution (if applicable)

No response

Removed private data

  • I have removed all private data from the configuration file and the logs

Code of Conduct

  • I agree to follow this project's Code of Conduct
@xabru xabru added the bug Something isn't working label Sep 14, 2024
@fl0ppy-d1sk
Copy link
Member

Hello @xabru,

Thanks for the issue.

Can you give us some practical examples so we can reproduce the problem and find a fix ?

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants