-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StandbyCount #893
Comments
Maybe #838 does this? I can't really tell. I don't care if they specifically use the AWS Warm Pool, I'm happy to pay for them to be running. Of course using the cost saving thing is better, I just need the speed for our builds right now. |
Hi @ptarjan this is an interesting idea! I think the warm pool could provide equivalent functionality in terms of performance 🤔 Could you share some numbers on your pool |
Yeah. The warm pool could work too but I’m assuming there is some
difficulty with it because you haven’t merged it yet.
My Min is 0 since I want to scale down at night to avoid pet machines
(hense me being interested in max lifetime), and my Max is currently 200.
During the day we will get up to around 150 instances right now. I would
set StandbyCount to 5 probably. Our warmup time is currently 10 minutes so
I will want to adjust based on build velocity and warmup time. I basically
want 0 wait time for our builds as our warmup time grows. I expect warmup
time to double every year with the build cache population time.
…On Thu, Aug 26, 2021 at 6:24 PM Keith Duncan ***@***.***> wrote:
Hi @ptarjan <https://github.com/ptarjan> this is an interesting idea! I
think the warm pool could provide equivalent functionality in terms of
performance 🤔
Could you share some numbers on your pool Min and Max size, and what
value you’d use for a StandbyCount? I’m curious how far off of a curve
fit ScaleOutFactor would be in the range you’re using 🤔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#893 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJZT2MQIRTTSAQ5VCDJQDT63SLBANCNFSM5C4I6HVQ>
.
|
You have
ScaleOutFactor
which is great if you want to scale out faster, andMinSize
to make sure we don't get too small but I want to just have 5 instances always spun up ready to take the next workload. Basically an additive number instead of the multiplicative one you have withScaleOutFactor
.I don't care about the name if you have a better suggestion than
StandbyCount
.The text was updated successfully, but these errors were encountered: