Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PagerDuty notifications are documented as an Anti-Pattern #1479

Open
bforte opened this issue May 4, 2022 · 0 comments
Open

PagerDuty notifications are documented as an Anti-Pattern #1479

bforte opened this issue May 4, 2022 · 0 comments

Comments

@bforte
Copy link

bforte commented May 4, 2022

Reading through Sending Change Events from your pipeline it seems that I should be storing the Integration API Key in the pipeline. However, this is documented as an anti-pattern: Anti-pattern: Storing secrets in your pipeline.yml because that API key should be a secret.

Since this integration is tightly coupled to Buildkite, the documentation should be improved. These things are not clear:

  • Is pagerduty_change_event going to be redacted?
  • What is the recommended way of storing this secret in a static pipeline?

Moreover, I believe that there should be a warning somewhere in the documentation. Currently, people might just go ahead and store their secret in a pipeline (ref) because it seems like it is the official recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant