Skip to content

Commit 7e27bd3

Browse files
committed
fix failing tests
* remove `test_peru_file_and_sync_dir_must_be_set_together` since that rule is removed * fix the behavior and formatting of `--cache-dir` and `--state-dir` params
1 parent 50d5540 commit 7e27bd3

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

peru/runtime.py

+10-4
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,17 @@ def _set_paths(self, args, env):
8585
self.peru_file = find_project_file(os.getcwd(), basename)
8686
self.sync_dir = os.path.dirname(self.peru_file)
8787

88-
self.state_dir = os.path.abspath(
89-
args['--state-dir']) if args['--state-dir'] else os.path.join(self.sync_dir, '.peru')
88+
if args['--state-dir']:
89+
self.state_dir = os.path.abspath(args['--state-dir'])
90+
else:
91+
self.state_dir = os.path.join(self.sync_dir, '.peru')
9092

91-
self.cache_dir = os.path.abspath(
92-
args['--cache-dir']) if args['--cache-dir'] else os.path.join(self.state_dir, 'cache')
93+
if args['--cache-dir']:
94+
self.cache_dir = os.path.abspath(args['--cache-dir'])
95+
elif env.get('PERU_CACHE_DIR'):
96+
self.cache_dir = env.get('PERU_CACHE_DIR')
97+
else:
98+
self.cache_dir = os.path.join(self.state_dir, 'cache')
9399

94100
def tmp_dir(self):
95101
dir = tempfile.TemporaryDirectory(dir=self._tmp_root)

tests/test_paths.py

-5
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,6 @@ def test_unmodified_sync(self):
4646
shared.run_peru_command(['sync'], self.cwd)
4747
self.assert_success(self.project_dir, self.state_dir, self.cache_dir)
4848

49-
def test_peru_file_and_sync_dir_must_be_set_together(self):
50-
for command in [['--sync-dir=junk', 'sync'], ['--file=junk', 'sync']]:
51-
with self.assertRaises(CommandLineError):
52-
shared.run_peru_command(command, cwd=self.cwd)
53-
5449
def test_file_and_file_basename_incompatible(self):
5550
with self.assertRaises(CommandLineError):
5651
shared.run_peru_command([

0 commit comments

Comments
 (0)