Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adoption-center image tag with skaffold #1

Open
LittleBaiBai opened this issue Sep 1, 2021 · 0 comments
Open

Update adoption-center image tag with skaffold #1

LittleBaiBai opened this issue Sep 1, 2021 · 0 comments

Comments

@LittleBaiBai
Copy link
Member

Currently, the adoption-center image that the operator uses to deploy does not contain a tag. Which means, if you are making local changes to that module, skaffold will build and tag the image, but because the operator deployment manifest doesn't use that new image tag, operator will still set adoption-center image without tag. With the current deployment logic, you will need to either manually update that deployment manifest with the correct image tag to be able to test your adoption-center changes.

Ways to solve this:

  • Add pre-deploy hook to modify that deployment manifest yaml with the generated tag (yq or sed).
  • Add kustomize overlay to to overwrite that image tag
  • Use a proper templating tool (helm or ytt)
  • ...

Since this is only a sample app, it's not crucial to have this issue. But if you are using this in production, you should find a better way to manage your images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant