Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable phpstan? #129

Open
roxblnfk opened this issue Jun 23, 2024 · 2 comments
Open

Disable phpstan? #129

roxblnfk opened this issue Jun 23, 2024 · 2 comments
Labels
maintenance CI, dependencies etc

Comments

@roxblnfk
Copy link
Member

phpstan produces a lot of false-positive alerts.

I'm considering to turn it off in CI.

@roxblnfk roxblnfk added the maintenance CI, dependencies etc label Jun 23, 2024
@Kaspiman
Copy link

Let's add Rector to the project. Then we could use Rector + Phpstan for fixing type errors. Also you can disable some fuzzy checks like https://github.com/buggregator/trap/blob/master/phpstan-baseline.neon#L1019

@roxblnfk
Copy link
Member Author

roxblnfk commented Jun 29, 2024

I think Rector may break our elegant code style.
Let's add it without CI, as a composer command. And without changes in SRC because I'm coding a big feature in progress and I don't want to have conflicts 🙀

After local testing we will consider adding it in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance CI, dependencies etc
Projects
None yet
Development

No branches or pull requests

2 participants