Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListAddList in JS/TS should use .push(..., not .concat #498

Open
JoshuaKGoldberg opened this issue Oct 27, 2018 · 0 comments
Open

ListAddList in JS/TS should use .push(..., not .concat #498

JoshuaKGoldberg opened this issue Oct 27, 2018 · 0 comments
Labels
bug good first issue hacktoberfest help wanted language: JavaScript language: TypeScript

Comments

@JoshuaKGoldberg
Copy link
Member

What's going on?

.concat creates a new list without modifying the original.

list add list : first second

Expected

first.push(...second)

Actual

first.concat(second)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue hacktoberfest help wanted language: JavaScript language: TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg