Added migration to eslint #49
Conversation
| @@ -0,0 +1,39 @@ | |||
| comment-type does not yet have an ESLint equivalent. | |||
There was a problem hiding this comment.
Heh, no need to check this in. Let's just remove it.
| sourceType: "module", | ||
| }, | ||
| plugins: ["@typescript-eslint", "@typescript-eslint/tslint"], | ||
| rules: { |
There was a problem hiding this comment.
This is a lot of rules to enable! Let's extend from the list of rules defined in the plugins.
Example reference: https://github.com/typescript-eslint/tslint-to-eslint-config/pull/229/files#diff-e4403a877d80de653400d88d85e4801aR6
| "space-before-function-paren": "off", | ||
| "use-isnan": "error", | ||
| yoda: "error", | ||
| "@typescript-eslint/tslint/config": [ |
There was a problem hiding this comment.
Amusing that there are still so many not yet implemented. You can go ahead and not include this list of tslint/config rules. I'm ok with them not being enabled any more. 😮
| "tslint": "5.20.0", | ||
| "tslint-config-prettier": "^1.18.0" | ||
| "tslint": "^5.20.0", | ||
| "tslint-config-prettier": "^1.18.0", |
There was a problem hiding this comment.
These two tslint packages should be removed. I think that'll be possible once the tslint/config rules are no longer included?
|
Ping, still interested @Dmytraw ? |
Resolves #48