Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: search through matchers in more intelligent order #8

Open
JoshuaKGoldberg opened this issue Jul 17, 2017 · 0 comments
Open

Comments

@JoshuaKGoldberg
Copy link
Member

Blindly searching through all potential matchers is expensive. There should be class that provides the matchers in an iterable order of the most likely to be hit. Some optimizations that come to mind:

  • Keep a mapping of command names to matchers that are only allowed as shallow ones
    • Maybe also deep ones, after that?

Each search will need a map of which commands have already been attempted to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant