Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally choose whether merge! preserves involved output indices of first Quantum or last Quantum #243

Open
mofeing opened this issue Nov 11, 2024 · 0 comments
Open

Optionally choose whether merge! preserves involved output indices of first Quantum or last Quantum #243

mofeing opened this issue Nov 11, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mofeing
Copy link
Member

mofeing commented Nov 11, 2024

Currently, in simple_update! for AbstractAnsatz, we need to manually do the reindexing because we want to preserve the output indices of the first AbstractQuantum TN but merge!(::AbstractQuantu, ::AbstractQuantum) preserves the output indices of the last Quantum.

Giving users this options would simplify the 2-site simple_update! implementation and avoid some bugs.
@mofeing mofeing added enhancement New feature or request good first issue Good for newcomers labels Nov 11, 2024
@mofeing mofeing mentioned this issue Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mofeing