Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify DryRun flag is wrapping all database updates #508

Open
pharr117 opened this issue Oct 29, 2023 · 0 comments
Open

Verify DryRun flag is wrapping all database updates #508

pharr117 opened this issue Oct 29, 2023 · 0 comments
Assignees
@pharr117
Labels
bug Something isn't working

Comments

@pharr117
Copy link
Collaborator

We need to verify/update all locations that DB write operations operation are respecting the dry run flag.

The Denom function called AddUnknownDenom is definitely not respecting it which we need to update, but we should loop through the code and make sure other locations are as well.
@pharr117 pharr117 added the enhancement New feature or request label Oct 29, 2023
@pharr117 pharr117 self-assigned this Oct 29, 2023
@pharr117 pharr117 added bug Something isn't working and removed enhancement New feature or request labels Oct 29, 2023
@danbryan danbryan moved this to Todo in Defiant OSS Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pharr117 pharr117

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pharr117