Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do data delete and recreate during reindex instead of create or update #472

Open
pharr117 opened this issue Sep 12, 2023 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@pharr117
Copy link
Collaborator

We do create or update operations on the TaxableTransaction data type:

https://github.com/DefiantLabs/cosmos-indexer/blob/8ce9576bb5f4bd837c1359d4eede52da48fbb42f/db/db.go#L283-L309

The problem is highlighted in the comment at the top of the code "Keying off of msg ID and amount may be sufficient....". This will not be sufficient during reindex operations. If the reindex is happening due to a bug in amount handlers such that a message returns a different amount, this will lead to data duplication.

@pharr117 pharr117 added bug Something isn't working enhancement New feature or request labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant