Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ Pagetype is generated in automatic Breadcrumb #121

Closed
dgorges opened this issue Aug 13, 2024 · 0 comments
Closed

FAQ Pagetype is generated in automatic Breadcrumb #121

dgorges opened this issue Aug 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dgorges
Copy link

dgorges commented Aug 13, 2024

There has been a ticket that if a FAQPage is selected, the FAQPage is created in the breadcrumb. #101. This has been solved. Thank you for that. But in the automatic breadcrumb of the eventlistener there is still the pagetype selected and causes Google to mark this as an error.

Therefore, the file: schema/Classes/EventListener/AddBreadcrumbList.php has to be updated also.

$givenItemType = ($page['tx_schema_webpagetype'] ?? '') ?: 'WebPage'; -> $givenItemType = 'WebPage';

After that, the behavior is streamlined with the breadcrumb viewhelper.

@brotkrueml brotkrueml self-assigned this Aug 13, 2024
@brotkrueml brotkrueml added the bug Something isn't working label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants