Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: set_struts wrong with large DPI #1961

Open
Caellian opened this issue Jun 7, 2024 · 2 comments
Open

[Bug]: set_struts wrong with large DPI #1961

Caellian opened this issue Jun 7, 2024 · 2 comments
Assignees
Labels
bug related to incorrect existing implementation of some functionality display: x11 related to X11 backend struts related to conky reserving space along screen edge

Comments

@Caellian
Copy link
Collaborator

Caellian commented Jun 7, 2024

Reported by @zygfryd

Desktop reserved space (in panel mode) seems to be double the actual window size.

When Xft.dpi: 192 (2x default).

After testing with test/workaread-adjustments which applies DPI left and applies inverse on the right margin,

Left alignment results in 3x reserved space (tested by maximizing a window), right alignment results in no reserved space.

Not sure whether right alignment can be fully trusted in the test because it could be affected my left alignment. It looks like window.geometry stores premultiplied values, and X11 expects logical position.

Related function: x11.cc/set_struts

Broken by #1910, #1862, or #1849.

@Caellian Caellian added the display: x11 related to X11 backend label Jun 7, 2024
@Caellian Caellian self-assigned this Jun 7, 2024
@Caellian Caellian added the bug related to incorrect existing implementation of some functionality label Jun 7, 2024
@zygfryd
Copy link

zygfryd commented Jun 7, 2024

I just realized that right alignment wouldn't have worked because of having multiple monitors and testing on the left monitor. I edited inverse scaling on the left side, and that worked correctly.

@Caellian
Copy link
Collaborator Author

Caellian commented Jul 4, 2024

PR #1963 reversed set_struts code. This issue might still persist, just linking it here for context. I'll work on it some time this week.

@Caellian Caellian added the struts related to conky reserving space along screen edge label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug related to incorrect existing implementation of some functionality display: x11 related to X11 backend struts related to conky reserving space along screen edge
Projects
None yet
Development

No branches or pull requests

2 participants