-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview & Load Feature #2834
Merged
Merged
Preview & Load Feature #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
philrz
approved these changes
Oct 23, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview and Load Steps
Dropzone
Form
Shaper Toolbar
Choose a saved shaper dropdown(Postponed)Results Pane
Original results
Shaped Results
Results Instance
Number of unique fields(Postponed)Submit Form to Existing Pool
What about PCAPs?
The loader should first run brim cap and output results to a file, that file could then be “preview and loaded”.
Phil's findings during testing (see links to comments below)
zq
processes are left running after cancelling out of Preview & Load of a large file (link)zq
is or why it's relevant here (link)zq
process left running after clicking "x" to abort a Load in progress (link)Inconsistent Expand/Collapse buttons in respective Table views in Preview & Load vs. main query results screen (link)PostponedFixes #2660