Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview & Load Feature #2834

Merged
merged 72 commits into from
Oct 24, 2023
Merged

Preview & Load Feature #2834

merged 72 commits into from
Oct 24, 2023

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Aug 4, 2023

Preview and Load Steps

Dropzone

  • Save that data to the form
  • Display a cool drop zone
  • Drag a file onto the app

Form

  • Create the container for the form on the right sidebar
  • Data Input
  • Pool Input
    • Dropdown options
    • Mother when existing pool
    • Pool Name field
    • Pool Key Auto Complete
    • Sort order dropdown
  • Commit message Text Area
  • Author field
  • Cancel Button
  • Load Button

Shaper Toolbar

  • Choose a saved shaper dropdown (Postponed)
  • Run button

Results Pane

  • Container
  • Split the container in two

Original results

  • Display original data result in a results pane

Shaped Results

  • Run the shaper and output the results in that pane

Results Instance

  • View Chooser
  • Number of unique fields (Postponed)
  • Number of types
  • Number of rows

Submit Form to Existing Pool

  • Create a pool first with all the settings
  • Or select the existing pool
  • Stream the data through zq into the zed load
    • Add the shaper script
    • Add the commit
    • Add the author

What about PCAPs?

The loader should first run brim cap and output results to a file, that file could then be “preview and loaded”.

Phil's findings during testing (see links to comments below)

  • Status bar shows "0 Types" and "Rows" without a number when loading large files (link)
  • zq processes are left running after cancelling out of Preview & Load of a large file (link)
  • Prior shaper is cached for loads to different pools (link)
  • Vertical carets in column headers of Table view don't do anything (link)
  • Errors when mixing different files types in the same Preview & Load (or loading any Parquet) (link)
  • No indication is given that the user is being shown only the first 100 rows (link)
  • "ZQ Errors" may be appear, but it may not be clear to the user what zq is or why it's relevant here (link)
  • Message portion of the configurable Commit Settings don't seem to be making it through intact (link)
  • A "quick load" option to bypass the Preview step might be useful (link)
  • Settings/Preferences doesn't appear if clicked when Preview & Load is already open (link)
  • Maintain default behavior & preserve existing setting for "Run Query On" (link)
  • Maintain default setting for Sort Order (link)
  • Table view in Preview & Load seems broken (link)
  • Load can be clicked multiple times, initiating redundant load operations (link)\
  • Add Custom Views to the preview and load page
  • Don't delete pool if load fails
  • Display load errors in the UI either a modal or collapsed section.
  • If you have a deleted pool, then you drag data into the app, the pool selection is empty
  • zq process left running after clicking "x" to abort a Load in progress (link)
  • Inconsistent Expand/Collapse buttons in respective Table views in Preview & Load vs. main query results screen (link) Postponed
  • A la carte pool creation pop-up still defaults to "Ascending" (link)
  • Clicking Load for second new pool doesn't bring up that pool's summary page (link)
  • Hitting Enter with expanded Pool Settings causes load to fail (link)

Fixes #2660

@philrz

This comment was marked as resolved.

@philrz

This comment was marked as resolved.

@philrz

This comment was marked as resolved.

@philrz

This comment was marked as resolved.

@philrz philrz self-requested a review October 23, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Load successful" pop-up to reflect partial loads
2 participants