Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEGV crash when maximizing window on Linux #3089

Closed
philrz opened this issue Jun 10, 2024 · 1 comment · Fixed by #3090
Closed

SIGSEGV crash when maximizing window on Linux #3089

philrz opened this issue Jun 10, 2024 · 1 comment · Fixed by #3090
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Jun 10, 2024

Repro is with Zui commit ca047c0. I bumped into this issue while going through the test permutations on all platforms before merging #3084.

The first repro video is taken with Zui Insiders release 1.7.1-12 which is based on Zui commit ca047c0. As we can see, the app initially launches ok, but then when I double-click the title bar to maximize the window, the app window disappears due to a crash.

Repro.mp4

The second repro video is taken by starting Zui in Dev Mode at commit ca047c0. This more clearly shows the root cause of the crash being an Electron SIGSEGV.

Repro-Dev-Mode.mp4

That Zui commit ca047c0 happens to be related to #3061 where Zui's Electron dependency was advanced from 28.0.0 to 30.0.1. In follow-on Dev Mode tests I advanced the Electron dependency one patch release at a time and found the problem went away at Electron 30.0.5. Sure enough, there's an Electron issue electron/electron#41839 that describes this exact symptom as having been fixed in Electron release v30.0.5, so we'll want to advance Zui's Electron dependency to a release like this one that includes the fix.

(Side note: I initially found this issue on Rocky Linux (RPM installer) after not having seen it on Ubuntu Linux (DEB installer) and therefore thought incorrectly at first that it was installer-related. Of course, in hindsight I can see the problem has to do with saved app state, since coincidentally on my Ubuntu VM I happened to have previously had Zui launched in a non-maximized state and didn't happen to have a reason to maximize it, so I didn't happen to bump into this bug in my testing there. By comparison, on my Rocky Linux VM I don't think I'd previously done any testing with Zui Insiders, so upon first launch the app window happened to be maximized, triggering the bug.)

@philrz
Copy link
Contributor Author

philrz commented Jun 12, 2024

Verified in Zui Insiders 1.7.1-27 which is based on Zui commit 8cec81d.

As shown in the attached video, now we can maximize the Zui app window without triggering a crash.

Verify.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant