Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text chopped off in "Update Available" pop-up #3074

Closed
philrz opened this issue May 18, 2024 · 1 comment · Fixed by #3083
Closed

Text chopped off in "Update Available" pop-up #3074

philrz opened this issue May 18, 2024 · 1 comment · Fixed by #3083
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented May 18, 2024

Repro is with Zui Insiders 1.7.1-2.

At Zui Insiders 1.7.1-1 and earlier, the "Update Available" pop-up looked like this:

image

Starting with 1.7.1-2, the pop-up now has the destination version out of view, and even the visible text is cropped (notice the missing tail on the "p" in "Update").

image

I've confirmed via binary search that this was caused by the changes in #3044.

@philrz philrz added the bug Something isn't working label May 18, 2024
@philrz
Copy link
Contributor Author

philrz commented Jun 10, 2024

Verified in Zui Insiders 1.7.1-25, which is based on Zui commit 5fa9071.

Here's the fixed pop-up on macOS that now has the version string visible again.

image

Here's the same on Windows.

image

#3082 makes it difficult for me to verify this on Linux, but since it's working on other platforms I'm ok accepting on faith that it's fixed on Linux too. 😄

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants