Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKV2_AWS_5: SG attached not recognized in DMS serverless #6628

Closed
makmnr opened this issue Aug 1, 2024 · 3 comments · Fixed by #6630
Closed

CKV2_AWS_5: SG attached not recognized in DMS serverless #6628

makmnr opened this issue Aug 1, 2024 · 3 comments · Fixed by #6630
Labels
checks Check additions or changes

Comments

@makmnr
Copy link
Contributor

makmnr commented Aug 1, 2024

The issue
Check fails even when the security group is attached to resource (DMS replication config/ DMS serverless)

Example

resource "aws_security_group" "my_sg" {
...
}

resource "aws_dms_replication_config" "migration_instance" {
...
compute_config {
vpc_security_group_ids = [aws_security_group.dms_sg.id]
}
depends_on = [aws_security_group.dms_sg]
}

Version
Checkov Version 3.2.84

@bhean
Copy link
Contributor

bhean commented Aug 19, 2024

Same here... in my case, the SG is attached to a DocumentDB database (aws_docdbelastic_cluster), but the check CKV2_AWS_5 is failing as well...

@makmnr
Copy link
Contributor Author

makmnr commented Aug 20, 2024

Quick fix would be to skip the check, or raise a PR to fix the issue similar to what I have done. But it is pending for review from few weeks now!!

@bhean
Copy link
Contributor

bhean commented Aug 27, 2024

Yes, you are right! I already sent a pull-request (similar to this one) fixing the issue that I found.
I hope both pull-requests will be reviewed soon, thanks!

itai1357 added a commit that referenced this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checks Check additions or changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants