Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LocalDateRange::getStart() / getEnd() #37

Open
BenMorel opened this issue Jun 29, 2021 · 2 comments
Open

Rename LocalDateRange::getStart() / getEnd() #37

BenMorel opened this issue Jun 29, 2021 · 2 comments

Comments

@BenMorel
Copy link
Member

BenMorel commented Jun 29, 2021 •
edited
Loading

to getStartDate() / getEndDate(). Will require a version bump.
@BenMorel BenMorel changed the title Rename LocalDateRange::getStart()/getEnd() to getStartDate()/getEndDate() Rename LocalDateRange::getStart()/getEnd() Jun 29, 2021
@BenMorel BenMorel changed the title Rename LocalDateRange::getStart()/getEnd() Rename LocalDateRange::getStart()/getEnd() Jun 29, 2021
@BenMorel BenMorel changed the title Rename LocalDateRange::getStart()/getEnd() Rename LocalDateRange::getStart() / getEnd() Jun 29, 2021
@BenMorel
Copy link
Member Author

Oops, this was already like this before, and was changed in #13, for consistency with YearMonthRange::getStart() / getEnd().

Not sure what the best move is here.

@jurchiks
Copy link

Should have deprecated the non-*Date methods in YearMonthRange instead of removing the suffix from the LocalDateRange methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jurchiks @BenMorel