Update Button.ps1 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run the button command I get the following error "Cannot find path 'C:\Users\dean.west\Documents\PowerShell\Modules\MsftTeams\1.0.0\public\internal\ButtonJsonTemplate.psd1' because it does not exist." Looking at the repo internal should be private and when I run $PSScriptRoot. It automatically defined the fully-qualified filesystem path to the directory that contains the button script file. C:\Users\dean.west\Documents\PowerShell\Modules\MsftTeams\1.0.0\public I am a novice and added the code I know fixes the issue but I do not know if it's the most efficient way to get the path.
Comment on lines
+57
to
+58
| $scriptPath = split-path -parent $PSScriptRoot | ||
| $buttonhash = Import-PowerShellDataFile $scriptPath\private\ButtonJsonTemplate.psd1 |
There was a problem hiding this comment.
I think I must have renamed the folder from internal to private before publishing to the gallery so just changing from internal to private should be enough to fix the issue.
Suggested change
| $scriptPath = split-path -parent $PSScriptRoot | |
| $buttonhash = Import-PowerShellDataFile $scriptPath\private\ButtonJsonTemplate.psd1 | |
| $buttonhash = Import-PowerShelldataFile $PSScriptRoot\Private\ButtonJsonTemplate.psd1 |
I will have to verify if this is the case though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run the button command I get the following error "Cannot find path 'C:\Users\dean.west\Documents\PowerShell\Modules\MsftTeams\1.0.0\public\internal\ButtonJsonTemplate.psd1' because it does not exist."
Looking at the repo internal should be private and when I run $PSScriptRoot. It automatically defined the fully-qualified filesystem path to the directory that contains the button script file. C:\Users\dean.west\Documents\PowerShell\Modules\MsftTeams\1.0.0\public
I am a novice and added the code I know fixes the issue but I do not know if it's the most efficient way to get the path.