Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some classes in the collections library are deprecated #258

Open
ortunoa opened this issue Feb 15, 2023 · 2 comments
Open

Some classes in the collections library are deprecated #258

ortunoa opened this issue Feb 15, 2023 · 2 comments

Comments

@ortunoa
Copy link

ortunoa commented Feb 15, 2023

Obd uses MutableMapping and Mapping, which are in util.py and chainmap.py

"from collections import Mapping" needs to be changed to "from collections.abc import Mapping" on util.py
"from collections import MutableMapping" needs to be changed to "from collections.abc import MutableMapping" on chainmap.py

@lamemakes
Copy link

lamemakes commented May 18, 2023

How did you install the package? There's a discrepancy between what's in the repo and what's in pypi (pip). For me, the pint issues were revolved via: python3 -m pip install git+https://github.com/brendan-w/python-OBD#egg=obd instead of the suggested python3 -m pip install obd. See #252 for more.

Not sure what the state of the project is now, but some docs updates & a new package release would be sweet.

@CaptainKatsuura
Copy link

How did you install the package? There's a discrepancy between what's in the repo and what's in pypi (pip). For me, the pint issues were revolved via: python3 -m pip install git+https://github.com/brendan-w/python-OBD#egg=obd instead of the suggested python3 -m pip install obd. See #252 for more.

Not sure what the state of the project is now, but some docs updates & a new package release would be sweet.

in trying this, importing OBD failed due to the pint requirement. Detailed it in #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants