[iOS] - Add alert for mobile config download #27115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
added
CI/skip-android
kylehickinson
requested changes
Jan 3, 2025
| @@ -744,7 +744,26 @@ extension BrowserViewController: WKNavigationDelegate { | |||
| let mimeType = response.mimeType.flatMap({ UTType(mimeType: $0) }), | |||
| mimeTypesThatRequireSFSafariViewControllerHandling.contains(mimeType) | |||
| { | |||
| handleLinkWithSafariViewController(url, tab: tab) | |||
There was a problem hiding this comment.
This handles other mime types as well not just mobile configurations
There was a problem hiding this comment.
Hmm I think it should do it also for the calendar type.
So both the calendar and the mobile config since you can do the same issue on both.
I'll have to change the text I guess, to handle both.
There was a problem hiding this comment.
Fixed. Added calendar support.
| comment: "Title of the alert when a mobile configuration profile is available for download" | ||
| ) | ||
| public static let openMobileConfigurationAlertDescription = NSLocalizedString( | ||
| "OpenMobileConfigurationAlertTitle", |
| "OpenTextCalendarAlertTitle", | ||
| tableName: "BraveShared", | ||
| bundle: .module, | ||
| value: "Calendar available", |
There was a problem hiding this comment.
May want to say "calendar event" or something along those lines instead
stoletheminerals
approved these changes
Jan 3, 2025
kylehickinson
approved these changes
Jan 3, 2025
|
Released in v1.75.149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves brave/brave-browser#43092
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: