Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a is not capitalized in "Ads received this month" string #42697

Closed
Miyayes opened this issue Dec 5, 2024 · 5 comments · Fixed by brave/brave-core#26891
Closed

a is not capitalized in "Ads received this month" string #42697

Miyayes opened this issue Dec 5, 2024 · 5 comments · Fixed by brave/brave-core#26891
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude rewards-3.0
Milestone
1.75.x - Beta

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 5, 2024

The first a should be capitalized.

Image

cc: @LaurenWags @GeetaSarvadnya
@github-project-automation github-project-automation bot moved this to New Issues in Brave Rewards Dec 5, 2024
@zenparsing zenparsing mentioned this issue Dec 5, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from New Issues to Done in Brave Rewards Dec 6, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 6, 2024
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 24, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 24, 2024 •
edited
Loading

Verification PASSED on

Brave | 1.75.120 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | 40377a8240bf613aa4c4cf7bce6283e73c2d1a48
OS | Windows 10 Version 22H2 (Build 19045.5247)
  • Confirmed that a is capitalized in Ads received this month string on brave://rewards settings page
  • Confirmed that a is capitalized in Ads received this month string on BR panel
  • Confirmed that a is capitalized in Ads received this month string on publisher banner panel
  • Confirmed that a is capitalized in Ads received this month string on the Rewards widget on NTP
brave://rewards BR panel publisher banner Rewards widget on NTP
Image Image Image Image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 24, 2024
@Miyayes Miyayes changed the title a is not not capitalized in "Ads received this month" string a is not capitalized in "Ads received this month" string Jan 6, 2025
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 6, 2025

Looks like a is not capitalized in the non-connected state case: Image
@GeetaSarvadnya

@LaurenWags
Copy link
Member

@Miyayes we probably need a separate issue for this since it's not the same exact string as mentioned when this was initially logged.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 7, 2025 •
edited
Loading

Yup, filed! Interestingly, the "Ads" in the connected state is capitalized properly (i.e., the Ads in the same position as the problematic one in the non-connected state and not the "ads received this month" string)!

@LaurenWags
Copy link
Member

thanks for logging the follow up issue @Miyayes 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude rewards-3.0
Projects
Brave Rewards
Status: Done
Milestone
1.75.x - Beta
Development

Successfully merging a pull request may close this issue.

[Rewards 3.0] Add small UI improvements brave/brave-core
5 participants
@zenparsing @Miyayes @LaurenWags @GeetaSarvadnya @brave-builds