Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VPN widget metrics #42515

Closed
DJAndries opened this issue Nov 26, 2024 · 3 comments · Fixed by brave/brave-core#26748
Closed

Add VPN widget metrics #42515

DJAndries opened this issue Nov 26, 2024 · 3 comments · Fixed by brave/brave-core#26748
Assignees
@DJAndries
Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) feature/vpn features/P3A OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.75.x - Beta

Comments

@DJAndries
Copy link
Collaborator

DJAndries commented Nov 26, 2024 •
edited
Loading

Add the following weekly metrics:

If you used the VPN NTP widget in the past week, how many actions did you perform within the widget in the past week?
Brave.VPN.WidgetUsage

  1. 1
  2. 2-10
  3. 11-20
  4. 21+

Did you hide the VPN widget this week?
Brave.VPN.HideWidget

  1. Yes

cc @rebron
@DJAndries DJAndries self-assigned this Nov 26, 2024
@DJAndries DJAndries mentioned this issue Nov 26, 2024
Merged
24 tasks
@DJAndries DJAndries added QA/Yes release-notes/exclude features/P3A OS/Desktop feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) feature/vpn labels Nov 26, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 28, 2024
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 10, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 10, 2024 •
edited
Loading

Verification PASSED on

Brave | 1.75.86 Chromium: 132.0.6834.33 (Official Build) nightly (64-bit)
-- | --
Revision | 0e6fd65d499de588288c231ca0aba711876f5022
OS | Windows 10 Version 22H2 (Build 19045.5131)

Logged #43041

Brave.VPN.WidgetUsage

Brave.VPN.WidgetUsage =0_PASSED
  1. Clean profile 1.75.x
  2. Log into existing/new Brave VPN account
  3. Enable Brave VPN via NTP
  4. Open brave://local-state file
  5. Look for the metrics Brave.VPN.WidgetUsage
  6. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 0 as expected
    Image
  7. Close the browser
  8. Set the sys date ahead by 1 week
  9. Restart the browser
  10. Reload brave://local-state file
  11. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 0 as expected
Brave.VPN.WidgetUsage =1_PASSED

Case 1:

  1. Clean profile 1.75.x
  2. Log into existing/new Brave VPN account
  3. Enable Brave VPN via NTP
  4. Open brave://local-state file
  5. Look for the metrics Brave.VPN.WidgetUsage
  6. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 0 as expected
  7. Open an NTP and disable the Brave VPN
  8. Reload brave://local-state file
  9. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected
    Image
  10. Close the browser
  11. Set the sys date ahead by 1 week
  12. Restart the browser
  13. Reload brave://local-state file
  14. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected

Case 2:

  1. Clean profile 1.75.x
  2. Log into existing/new Brave VPN account
  3. Enable Brave VPN via NTP
  4. Open brave://local-state file
  5. Look for the metrics Brave.VPN.WidgetUsage
  6. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 0 as expected
  7. Open an NTP and disable the Brave VPN
  8. Reload brave://local-state file
  9. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected
    Image
  10. Interact with Brave VPN card via NTP widget for 10 times (e.g, enable or disable VPN, change the region to different countries etc...)
  11. Reload brave://local-state file
  12. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected
  13. Close the browser
  14. Set the sys date ahead by 1 week
  15. Restart the browser
  16. Reload brave://local-state file
  17. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected
Brave.VPN.WidgetUsage =2_PASSED

Case 1:

  1. Clean profile 1.75.x
  2. Log into existing/new Brave VPN account
  3. Enable Brave VPN via NTP
  4. Open brave://local-state file
  5. Look for the metrics Brave.VPN.WidgetUsage
  6. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 0 as expected
  7. Open an NTP and disable the Brave VPN
  8. Reload brave://local-state file
  9. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected
  10. Interact with Brave VPN card via NTP widget for 11 times (e.g, enable or disable VPN, change the region to different countries etc...)
    Image
  11. Reload brave://local-state file
  12. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 2 as expected
  13. Close the browser
  14. Set the sys date ahead by 1 week
  15. Restart the browser
  16. Reload brave://local-state file
  17. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 2 as expected

Case 2:

  1. Clean profile 1.75.x
  2. Log into existing/new Brave VPN account
  3. Enable Brave VPN via NTP
  4. Open brave://local-state file
  5. Look for the metrics Brave.VPN.WidgetUsage
  6. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 0 as expected
  7. Open an NTP and disable the Brave VPN
  8. Reload brave://local-state file
  9. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected
  10. Interact with Brave VPN card via NTP widget for 20 times (e.g, enable or disable VPN, change the region to different countries etc...)
    Image
  11. Reload brave://local-state file
  12. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 2 as expected
  13. Close the browser
  14. Set the sys date ahead by 1 week
  15. Restart the browser
  16. Reload brave://local-state file
  17. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 2 as expected
Brave.VPN.WidgetUsage =3_PASSED
  1. Clean profile 1.75.x
  2. Log into existing/new Brave VPN account
  3. Enable Brave VPN via NTP
  4. Open brave://local-state file
  5. Look for the metrics Brave.VPN.WidgetUsage
  6. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 0 as expected
  7. Open an NTP and disable the Brave VPN
  8. Reload brave://local-state file
  9. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 1 as expected
  10. Interact with Brave VPN card via NTP widget for 21+ times (e.g, enable or disable VPN, change the region to different countries etc...)
    Image
  11. Reload brave://local-state file
  12. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 3 as expected
  13. Close the browser
  14. Set the sys date ahead by 1 week
  15. Restart the browser
  16. Reload brave://local-state file
  17. Confirmed that the metrics Brave.VPN.WidgetUsage response value is 3 as expected

Brave.VPN.HideWidget

Brave.VPN.HideWidget = 1_PASSED
  1. Clean profile 1.75.x
  2. Log into existing/new Brave VPN account
  3. Enable Brave VPN via NTP and hide the VPN via NTP
  4. Open brave://local-state file
  5. Look for the metrics Brave.VPN.HideWidget
  6. Confirmed that the metrics Brave.VPN.HideWidget response value is 1 as expected
    Image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 24, 2024
@GeetaSarvadnya
Copy link

@DJAndries: When Brave VPN widget is hidden via NTP the metrics Brave.VPN.HideWidget response is 1 as expected, but If we add the card again (unhide) the Brave VPN widget via NTP then the response is still 1 instead of 0. Is this correct? the metrics will consider only the 1st event response (hide)?

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Dec 24, 2024
Closed
6 tasks
@DJAndries
Copy link
Collaborator Author

@DJAndries: When Brave VPN widget is hidden via NTP the metrics Brave.VPN.HideWidget response is 1 as expected, but If we add the card again (unhide) the Brave VPN widget via NTP then the response is still 1 instead of 0. Is this correct? the metrics will consider only the 1st event response (hide)?

Hey @GeetaSarvadnya , responded in #43041 (comment). thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) feature/vpn features/P3A OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.75.x - Beta
Development

Successfully merging a pull request may close this issue.

Add VPN widget metrics brave/brave-core
3 participants
@DJAndries @GeetaSarvadnya @brave-builds