Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep separate NTT P3A events for Constellation metrics #42108

Closed
DJAndries opened this issue Nov 6, 2024 · 1 comment · Fixed by brave/brave-core#26863
Closed

Keep separate NTT P3A events for Constellation metrics #42108

DJAndries opened this issue Nov 6, 2024 · 1 comment · Fixed by brave/brave-core#26863
Assignees
Labels
enhancement features/P3A OS/iOS Fixes related to iOS browser functionality QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Yes release-notes/exclude

Comments

@DJAndries
Copy link
Collaborator

In order to deprecate JSON reporting completely for iOS, we need to maintain separate NTT event counts for Constellation reporting. The rotated method in NewTabPageP3AHelper must acknowledge Constellation rotations.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 24, 2024

Verification INPROGRESS on iPhone 8 version 16.7.10 running on Brave Nightly 1.75 (118)

Step 1_PASSED
  • Confirmed that JSON metrics are sent as usual to the endpoint p3a-json.brave.com
  • Confirmed that each metric is sent to the server and marked as "sent" = true in the local state file

randomness metrics at http://p3a-json.brave.com/

Example Example Example Example Example Example Example Example Example Example Example Example
Image Image Image Image Image Image Image Image Image Image Image Image
  • Confirmed that if the metric is in the logs object (in local state), then the cadence is typical and the same is displayed in p3a-json.brave.com endpoint in the server
Example Example Example Example Example Example
Image Image Image Image Image Image
  • Confirmed that, If the metric is in logs_slow then the cadence is slow and same is displayed in the p3a-json.brave.com endpoint in the server
    Image

  • Confirmed that, If the metric is in logs_express then the cadence is express and the same is displayed in p3a-json.brave.com endpoint in the server

  • Only 2 metrics are shown under the logs_express and in p3a-json endpoint, I could see two cadence express metrics sent to the endpoint p3a-json.brave.com

Example p3a-json.brave.com p3a-json.brave.com
Image Image Image
Example Example
Image Image
  • Confirmed that the cadence field in the payload contains the correct value
  • The metrics Brave.Shields.AdBlockSettings response value is same on both local state file and p3a-json... endpoint
local-state p3a-json local-state p3a-json local-state p3a-json local-state p3a-json ocal-state p3a-json
Image Image Image Image Image Image Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement features/P3A OS/iOS Fixes related to iOS browser functionality QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants