Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sig-Auth Post-Acceptance TODOs #168

Open
13 tasks
ibihim opened this issue Apr 25, 2022 · 1 comment
Open
13 tasks

Sig-Auth Post-Acceptance TODOs #168

ibihim opened this issue Apr 25, 2022 · 1 comment

Comments

@ibihim
Copy link
Collaborator

ibihim commented Apr 25, 2022 •
edited
Loading

  • Consider updating tls-reload-interaval with k8s.io/apiserver code as it auto-reloads TLS (link, link)
  • Consider checking for the audience in the token provided (link).
  • Use k8s defaults for TTLs (link, link).
  • Safer checks on username config and other properties. Protect against typos and missing fields (link).
  • Add dedicated user input validation that matches k/k (link).

Unspecified

  • Use in-cluster CA (link)
  • http2 transport review (link, link)
  • Use aggregated apiserver proxy (link).
  • Don't create self-signed certs (link).

Minor

  • Rename from Matches to Equal (link).
  • Add test cases (link), link).
  • Always nil function (link).
  • Embedding types > delegation (link).

Related: Pre-Acceptance.
This was referenced Apr 25, 2022
Closed
Closed
@ibihim ibihim mentioned this issue Aug 17, 2022
Closed
@upodroid upodroid mentioned this issue Apr 2, 2024
Closed
@stlaz
Copy link
Collaborator

stlaz commented Nov 11, 2024 •
edited
Loading

per #251:

  • structured logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stlaz @ibihim