Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong types #305

Open
pupitooo opened this issue Nov 16, 2021 · 6 comments
Open

Wrong types #305

pupitooo opened this issue Nov 16, 2021 · 6 comments
Labels

Comments

@pupitooo
Copy link
Contributor

General information

  • SDK/Library version: 6.5.0

Issue description

I try to use v6.5.0 instead of our actual v6.4.1, but PhpStan found a lot of type errors.

Commit e35c2a2 is full types mistakes like this. Is it possible to fix this?

@hollabaq86
Copy link
Contributor

🙃 well, crud. Sorry about that. If you'd like to PR the fixes to the docs, please feel free to do so! I don't have an ETA on when these will get fixed up, but they will eventually get fixed.

@Tlapi
Copy link
Contributor

Tlapi commented Nov 22, 2021

#304

@hollabaq86
Copy link
Contributor

Going to turn this first issue on types into a mega-thread of issues similar issues opened.
See also #314

@hollabaq86
Copy link
Contributor

related PRs - #315

@hollabaq86
Copy link
Contributor

for internal tracking, ticket 1401

@hollabaq86
Copy link
Contributor

Lumping in #326 with this as well, in that this PR highlights that returns and throws need cleaning up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants