Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect logging level for the HTTP client #97

Open
mariuszdubielecki opened this issue Jan 15, 2021 · 2 comments
Open

Incorrect logging level for the HTTP client #97

mariuszdubielecki opened this issue Jan 15, 2021 · 2 comments

Comments

@mariuszdubielecki
Copy link

mariuszdubielecki commented Jan 15, 2021

In the HTTP client class com.braintreegateway.util.Http it is used INFO log level for logging every request which is sent to Braintree. This would produce a certain amount of logs on the server.

When you look at the documentation for INFO level java.util.logginghttps://docs.oracle.com/javase/8/docs/api/java/util/logging/Level.html#INFO

It says Typically INFO messages will be written to the console or its equivalent. So the INFO level should only be used for reasonably significant messages that will make sense to end users and system administrators.

I don't believe that sending a request to Braintree is the "significant message". It may be useful for debugging issues but not for every day usage.

@hollabaq86
Copy link
Contributor

👋 @mariuszdubielecki thanks for reaching out! You do raise a good point around our logging. We're going to leave this open and flag for review when we work on the next major version of this SDK.

@hollabaq86
Copy link
Contributor

for internal note-keeping, ticket 719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants