-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toString methods are missing #57
Comments
Thanks for the feedback, we'll take it into consideration. Adding this is not on our current roadmap, but I can see how it would be useful. As always, PRs are welcome! |
What in your opinion is the best approach of implementing toString() methods for SDK classes? Should it be some JSON like structure that represents all object properties or something more sophisticated, like for example this
What should be a date/time format of a string representation? |
Just the IDE generated toString() implementation is fine. For the date format you can just call the date objects toString() method. The response classes which are returned by the API are most important to have a toString() method. |
If such implementation of toString() method is fine for you, I'll prepare some PR in a couple of days. |
Hey all ! Just a quick update. We have taken this into consideration. We are fancying the idea of using lombok library to do the heavy lifting for us. Currently, the idea is to use it for |
Thanks for notification. As this is curretnly in progress, then no additional changes/pull requests will be needed from my side? |
A quick update. We have not forgotten you. We are running into issues using lombok with Java 7. We are working our way trying to fix that, and making a lot of new features from |
I am very interested in this feature (and/or #80). I am using Braintree in a language that runs on top of Java, but I am not a java developer so unfortunately I can't offer any hope of a PR. We need to store the charge response in our database for record-keeping, but the SDK returns java objects that are not serializable. The I can spelunk through the response methods and cobble together my own native-data representation of the result and then serialize that, but the number of possibilities that would need to be accounted for in the variations of response contents would be very high (for example, responses can be significantly different between charges made with cc/venmo/paypal/google pay/apple pay). |
for internal notekeeping, ticket 631 |
the library would be much easier to work with if there were toString() methods on the classes
The text was updated successfully, but these errors were encountered: