Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 support? #438

Open
melroy89 opened this issue May 19, 2016 · 2 comments
Open

Bootstrap 4 support? #438

melroy89 opened this issue May 19, 2016 · 2 comments

Comments

@melroy89
Copy link

melroy89 commented May 19, 2016

I can use sass with the bootstrap-sass bundle, but that is Bootstrap version 3...

I would like to use Bootstrap 4.0 (alpha) using bootstrap-bundle.
I already know how to configure sass in bootstrap-bundle.

But currently when I configure sass it tries to search in the boostrap-sass bundle (not wanted behaviour!). However the new Bootstrap 4.0 version has sass out of the box. This version is just located at: vendor/twbs/bootstrap.

Current composer.json setup:

"braincrafted/bootstrap-bundle": "dev-master",
"twbs/bootstrap": "4.0.*",
"symfony/assetic-bundle": "^2.8",

Thanks already for supporting Bootstrap 4 in the (hopefully) near future!

Kind regards,
Melroy van den Berg

lashus pushed a commit to lashus/bootstrap-bundle that referenced this issue Aug 10, 2016
@lashus
Copy link
Contributor

lashus commented Aug 10, 2016

As i've looked upon it there's much more. My fix is irrelevant and should be cleaned out of discussion. Js file list also differs, there should be some kind of "switch" between version. Also some classes have changed so the new branch is required for twbs v4.

@melroy89
Copy link
Author

Thanks for working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants