Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: renamed inner_emoji, changed select_menu and component to use it. #974

Merged
merged 4 commits into from
Oct 30, 2023
Merged

refactor: renamed inner_emoji, changed select_menu and component to use it. #974

merged 4 commits into from
Oct 30, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Oct 29, 2023 •
edited
Loading

This PR removed inner_select_emoji from select_menu and renames inner_emoji to component_emoji. select_menu now uses component_emoji.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 29, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 2cb11e0
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/653e6d41ddcf65000867aaba
😎 Deploy Preview https://deploy-preview-974--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 29, 2023
@Jaskowicz1 Jaskowicz1 changed the title refactor: moved inner_emoji, changed select_menu and component to use it. refactor: renamed inner_emoji, changed select_menu and component to use it. Oct 29, 2023
@Jaskowicz1
Copy link
Contributor Author

Renamed title and changed description to accurately reflect the new changes of this PR.

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review October 29, 2023 14:34
@Mishura4 Mishura4 merged commit 596e76e into brainboxdotcc:dev Oct 30, 2023
36 checks passed
@Jaskowicz1 Jaskowicz1 deleted the inner_emoji_changes branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mishura4 Mishura4 Mishura4 approved these changes

@braindigitalis braindigitalis Awaiting requested review from braindigitalis

Assignees
No one assigned
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaskowicz1 @Mishura4