Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for Premium App Subscriptions #969

Merged
merged 17 commits into from
Oct 25, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Oct 23, 2023

This PR adds all the new stuff for Premium App Subscriptions, allowing people to use discord's new app subscription stuff in their bots.

This PR is untested (hence the tickbox isn't ticked) and can't be tested due to no access to discord's monetisation (as I don't have a verified bot). We will only know this works when someone tests this with a verified bot (but that could be in months time).

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 self-assigned this Oct 23, 2023
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 9f13f1f
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6537a1c8fb011900085ae678
😎 Deploy Preview https://deploy-preview-969--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 23, 2023
@Jaskowicz1 Jaskowicz1 added the enhancement New feature or request label Oct 23, 2023
@Jaskowicz1
Copy link
Contributor Author

I can't properly test this PR due to the fact I do not have a verified bot, so i'm not applicable for the SKU/Entitlement stuff. Other than that, this PR is ready.

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review October 24, 2023 07:34
@braindigitalis braindigitalis merged commit 3eb549d into brainboxdotcc:dev Oct 25, 2023
34 checks passed
@Jaskowicz1 Jaskowicz1 deleted the subscription-addition branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants