Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added application and following support for webhooks. #960

Merged
merged 7 commits into from
Oct 21, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Oct 20, 2023

This PR adds a new webhook type called application, as specified by the discord documentation. It also now supports data from webhooks that Channel Follower Webhooks, as previously we didn't take in the source_guild, and source_channel data.

I've also changed user to be a user object.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit de20be1
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/653392d5a585a10008399b53
😎 Deploy Preview https://deploy-preview-960--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 20, 2023
@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review October 20, 2023 19:35
src/dpp/webhook.cpp Outdated Show resolved Hide resolved
@Jaskowicz1 Jaskowicz1 requested a review from Mishura4 October 21, 2023 09:09
@Mishura4 Mishura4 merged commit 82f9297 into brainboxdotcc:dev Oct 21, 2023
34 checks passed
@Jaskowicz1 Jaskowicz1 deleted the webhook-fixes branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants