Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont try to enable AVX on ARM (or any non x86_64/x86 arch) #815

Merged
merged 3 commits into from
Aug 28, 2023
Merged

fix: dont try to enable AVX on ARM (or any non x86_64/x86 arch) #815

merged 3 commits into from
Aug 28, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Aug 28, 2023 •
edited
Loading

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 5aa2c24
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64ed1112741f8c0008348953
😎 Deploy Preview https://deploy-preview-815--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis marked this pull request as ready for review August 28, 2023 20:12
RealTimeChris
RealTimeChris reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@RealTimeChris RealTimeChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

RealTimeChris
RealTimeChris reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@RealTimeChris RealTimeChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

RealTimeChris
RealTimeChris approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@RealTimeChris RealTimeChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@braindigitalis braindigitalis merged commit ab0e35d into dev Aug 28, 2023
45 of 48 checks passed
@braindigitalis braindigitalis deleted the cmake_dont_detect_avx_on_non_x86_64 branch August 28, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealTimeChris RealTimeChris RealTimeChris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braindigitalis @RealTimeChris