-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed cluster::guild_create, cluster::stage_instance_create and cluster::sticker_packs_get returning 404 Not Found #809
Conversation
fix: warning for [=] copy without explkit , rerun coro builder for on…
…cluster::sticker_packs_get returning 404 Not Found
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
You also haven't checked "I have ensured that I did not break any existing API calls." in the PR checklist, I'm assuming you're testing it now? I'll approve it when you check it |
tbh i would have to test almost all cluster methods to make sure nothing breaks. I won't do that lol. i can test a few manually if you want. i thought the unit tests cover some cluster methods and that may be enough 🤷. |
Yeah as long as you ran the unit tests and checked the ones you've changed that's fine I think! |
(Just make sure you do check the box to make openssf and the other things happy hehe) |
The ones this pr fixes aren't covered by the unit tests iirc. But i tested them manually of course. |
okay 😎 |
dev
branch.The post_rest methods did append a
/
when no major_parameters was passed. This affectedcluster::guild_create
,cluster::stage_instance_create
andcluster::sticker_packs_get
to return 404 Not found because the path was wrong with the appended slash!The
cluster::sticker_packs_get
method needed an extra fix too.