Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed cluster::guild_create, cluster::stage_instance_create and cluster::sticker_packs_get returning 404 Not Found #809

Merged
merged 13 commits into from
Aug 26, 2023

Conversation

Commandserver
Copy link
Member

@Commandserver Commandserver commented Aug 26, 2023

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

The post_rest methods did append a / when no major_parameters was passed. This affected cluster::guild_create, cluster::stage_instance_create and cluster::sticker_packs_get to return 404 Not found because the path was wrong with the appended slash!

The cluster::sticker_packs_get method needed an extra fix too.

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 7c98ac8
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64e9f9fb1519ac0008ba09ae
😎 Deploy Preview https://deploy-preview-809--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mishura4
Copy link
Member

You also haven't checked "I have ensured that I did not break any existing API calls." in the PR checklist, I'm assuming you're testing it now? I'll approve it when you check it

@Commandserver
Copy link
Member Author

Commandserver commented Aug 26, 2023

You also haven't checked "I have ensured that I did not break any existing API calls." in the PR checklist, I'm assuming you're testing it now? I'll approve it when you check it

tbh i would have to test almost all cluster methods to make sure nothing breaks. I won't do that lol. i can test a few manually if you want. i thought the unit tests cover some cluster methods and that may be enough 🤷.

@Mishura4
Copy link
Member

Yeah as long as you ran the unit tests and checked the ones you've changed that's fine I think!

@Mishura4
Copy link
Member

Mishura4 commented Aug 26, 2023

(Just make sure you do check the box to make openssf and the other things happy hehe)

@Commandserver
Copy link
Member Author

Yeah as long as you ran the unit tests and checked the ones you've changed that's fine I think!

The ones this pr fixes aren't covered by the unit tests iirc. But i tested them manually of course.

@Commandserver
Copy link
Member Author

(Just make sure you do check the box to make openssf and the other things happy hehe)

okay 😎

@Mishura4 Mishura4 merged commit 957b282 into brainboxdotcc:dev Aug 26, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants