Error when hiding / showing keyboard

[maztheman]

So when you try to hide after showing the keyboard, eventually you get the error listed below. Note the bolded hide(ime) line where the main thread is doing it. Seems this is what is causing the issue. Any thoughts? This causes the chrome insets to be calculated as if the keyboard was hidden even when the keyboard is shown.

04-02 13:30:27.118 24991 25017 D InsetsController: show(ime(), fromIme=false)
04-02 13:30:27.120 24991 25017 D InsetsController: Setting requestedVisibleTypes to -2 (was -10)
04-02 13:30:34.459 24991 24991 D InsetsController: hide(ime(), fromIme=false)
04-02 13:30:39.532 24991 25017 D InsetsController: show(ime(), fromIme=false)
04-02 13:30:39.532 24991 25017 D InsetsController: Setting requestedVisibleTypes to -2 (was -10)
04-02 13:30:52.003 24991 25017 W System.err: android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views. Expected: main Calling: Thread-2
04-02 13:30:52.004 24991 25017 W System.err: at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:11213)
04-02 13:30:52.004 24991 25017 W System.err: at android.view.ViewRootImpl.requestLayout(ViewRootImpl.java:2551)
04-02 13:30:52.004 24991 25017 W System.err: at android.view.ViewRootImpl.notifyInsetsChanged(ViewRootImpl.java:2513)
04-02 13:30:52.004 24991 25017 W System.err: at android.view.ViewRootInsetsControllerHost.notifyInsetsChanged(ViewRootInsetsControllerHost.java:56)
04-02 13:30:52.004 24991 25017 W System.err: at android.view.InsetsController.notifyVisibilityChanged(InsetsController.java:1884)
04-02 13:30:52.004 24991 25017 W System.err: at android.view.InsetsController.onAnimationStateChanged(InsetsController.java:1845)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.InsetsController.controlAnimationUncheckedInner(InsetsController.java:1563)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.InsetsController.controlAnimationUnchecked(InsetsController.java:1357)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.InsetsController.applyAnimation(InsetsController.java:2048)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.InsetsController.applyAnimation(InsetsController.java:2022)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.InsetsController.show(InsetsController.java:1177)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2426)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2376)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2368)
04-02 13:30:52.005 24991 25017 W System.err: at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2296)

[brackeen]

Hi @maztheman, thanks for the info. Can you give more details on how to reproduce this issue?

• Android API version this is running on.
• Steps to reproduce.
• Can this error be reproduced with the typing.c example code?

[maztheman]

I am running on a Pixel 6a, with android 15. The rest of the repro steps I will try to do with the typing.c example.

[maztheman]

OK I was able to repro the issue with typing.c

1. Run the App
2. on host PC run

adb logcat *:V| grep -F "`adb shell ps | grep com.example.native_activity | tr -s [:space:] ' ' | cut -d' ' -f2`"

to start logging
3) on device, TAP to show keyboard
4) TAP to hide keyboard
5) TAP to show keyboard, the logger will show the exception I pasted above.

[maztheman]

compileSdkVersion 29
    ndkVersion '28.0.13004108'

    defaultConfig {
        applicationId = 'com.example.native_activity'
        versionCode 1
        versionName "1.0"
        minSdkVersion 21
        targetSdkVersion 32
        externalNativeBuild {
            cmake {
                arguments '-DANDROID_STL=c++_static'
                cppFlags "-fexceptions -Werror -Wunused-function"
            }
        }
    }

This is the configuration for the build

[maztheman]

04-03 06:33:04.763 32688 32715 I ImeTracker: com.example.native_activity:a98337de: onRequestShow at ORIGIN_CLIENT reason SHOW_SOFT_INPUT fromUser false
04-03 06:33:04.764 32688 32715 D InsetsController: show(ime(), fromIme=false)
04-03 06:33:04.765 32688 32715 D InsetsController: Setting requestedVisibleTypes to -2 (was -10)
04-03 06:33:05.038 32688 32688 I ImeTracker: com.example.native_activity:a98337de: onShown
04-03 06:33:08.857 32688 32715 I ImeTracker: com.example.native_activity:60a00792: onRequestHide at ORIGIN_CLIENT reason HIDE_SOFT_INPUT fromUser false
04-03 06:33:08.858 32688 32688 D InsetsController: hide(ime(), fromIme=false)
04-03 06:33:08.864 32688 32688 W WindowOnBackDispatcher: sendCancelIfRunning: isInProgress=false callback=android.view.ImeBackAnimationController@27e0376
04-03 06:33:08.865 32688 32688 D InsetsController: Setting requestedVisibleTypes to -10 (was -2)
04-03 06:33:10.109 32688 32715 I ImeTracker: com.example.native_activity:a733f4e0: onRequestShow at ORIGIN_CLIENT reason SHOW_SOFT_INPUT fromUser false
04-03 06:33:10.109 32688 32715 D InsetsController: show(ime(), fromIme=false)
04-03 06:33:10.110 32688 32715 D InsetsController: Setting requestedVisibleTypes to -2 (was -10)
04-03 06:33:10.111 32688 32715 W System.err: android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views. Expected: main Calling: Thread-2
04-03 06:33:10.111 32688 32715 W System.err: 	at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:11213)
04-03 06:33:10.111 32688 32715 W System.err: 	at android.view.ViewRootImpl.requestLayout(ViewRootImpl.java:2551)
04-03 06:33:10.111 32688 32715 W System.err: 	at android.view.ViewRootImpl.notifyInsetsChanged(ViewRootImpl.java:2513)
04-03 06:33:10.112 32688 32715 W System.err: 	at android.view.ViewRootInsetsControllerHost.notifyInsetsChanged(ViewRootInsetsControllerHost.java:56)
04-03 06:33:10.112 32688 32715 W System.err: 	at android.view.InsetsController.notifyVisibilityChanged(InsetsController.java:1884)
04-03 06:33:10.112 32688 32715 W System.err: 	at android.view.InsetsController.onAnimationStateChanged(InsetsController.java:1845)
04-03 06:33:10.112 32688 32715 W System.err: 	at android.view.InsetsController.controlAnimationUncheckedInner(InsetsController.java:1563)
04-03 06:33:10.113 32688 32715 W System.err: 	at android.view.InsetsController.controlAnimationUnchecked(InsetsController.java:1357)
04-03 06:33:10.113 32688 32715 W System.err: 	at android.view.InsetsController.applyAnimation(InsetsController.java:2048)
04-03 06:33:10.113 32688 32715 W System.err: 	at android.view.InsetsController.applyAnimation(InsetsController.java:2022)
04-03 06:33:10.113 32688 32715 W System.err: 	at android.view.InsetsController.show(InsetsController.java:1177)
04-03 06:33:10.113 32688 32715 W System.err: 	at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2426)
04-03 06:33:10.114 32688 32715 W System.err: 	at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2376)
04-03 06:33:10.114 32688 32715 W System.err: 	at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2368)
04-03 06:33:10.114 32688 32715 W System.err: 	at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:2296)
04-03 06:33:10.322 32688 32688 I ImeTracker: com.example.native_activity:a733f4e0: onShown

[maztheman]

On step 4, something goes wrong, the hide(ime()) happens on the main thread (32688). Step 3 the show(ime()) happens on the "Thread-2" which is glfmMain thread.

[maztheman]

static void mmud__updateKeyboardVisibility(GLFMPlatformData *platformData, int visible);


static void mmud__updateKeyboardVisibilityCallback(GLFMPlatformData *platformData, void *userData) {
    intptr_t visible_ = (intptr_t)userData;
    mmud__updateKeyboardVisibility(platformData, (int)visible_);
}

static void mmud__updateKeyboardVisibility(GLFMPlatformData *platformData, int visible) {

    if (!platformData || !platformData->activity) {
        return;
    }
    const int SDK_INT = platformData->activity->sdkVersion;
    if (SDK_INT < 11) {
        return;
    }

    JavaVM *jvm = platformData->activity->vm;
    JNIEnv *jni = NULL;
    (*jvm)->GetEnv(jvm, (void **) &jni, JNI_VERSION_1_2);
    if (!jni || (*jni)->ExceptionCheck(jni)) {
        return;
    }

    jobject decorView = glfm__getDecorView(jni, platformData);
    if (!decorView) {
        return;
    }

    bool setNow = true;
    bool isUiThread = ALooper_forThread() == platformData->uiLooper;
    if (!isUiThread) {
        bool isDecorViewAttached;
        if (SDK_INT >= 19) {
            isDecorViewAttached = glfm__callJavaMethod(jni, decorView, "isAttachedToWindow", "()Z", Boolean);
        } else {
            isDecorViewAttached = glfm__callJavaMethod(jni, decorView, "getWindowToken", "()Landroid/os/IBinder;",
                                                       Object) != NULL;
        }
        if (glfm__wasJavaExceptionThrown(jni)) {
            (*jni)->DeleteLocalRef(jni, decorView);
            return;
        }
        setNow = !isDecorViewAttached;
    }

    if (!setNow) {
        // Set on the UI thread
        glfm__runOnUIThread(platformData, mmud__updateKeyboardVisibilityCallback, (void*)(intptr_t)visible);
    } else {
        // Set now
        if (SDK_INT >= 30) {
            jobject windowInsetsController = glfm__callJavaMethod(jni, decorView, "getWindowInsetsController",
                                                                  "()Landroid/view/WindowInsetsController;", Object);
            jclass windowInsetsTypeClass = (*jni)->FindClass(jni, "android/view/WindowInsets$Type");
            if (windowInsetsController && windowInsetsTypeClass && !glfm__wasJavaExceptionThrown(jni)) {

                const jint vkeyboard = glfm__callJavaStaticMethod(jni, windowInsetsTypeClass, "ime",
                                                                   "()I", Int);

                if (visible == 1) {
                    glfm__callJavaMethodWithArgs(jni, windowInsetsController, "show", "(I)V", Void, vkeyboard);
                } else {
                    glfm__callJavaMethodWithArgs(jni, windowInsetsController, "hide", "(I)V", Void, vkeyboard);
                }

                (*jni)->DeleteLocalRef(jni, windowInsetsController);
                (*jni)->DeleteLocalRef(jni, windowInsetsTypeClass);
                glfm__clearJavaException(jni);
            }
        }
    }
    (*jni)->DeleteLocalRef(jni, decorView);
}

static bool glfm__setKeyboardVisible(GLFMPlatformData *platformData, bool visible) {
    mmud__updateKeyboardVisibility(platformData, visible ? 1 : 0);
    return true;
}

this seemed to fix it.

[maztheman]

dont know about how to fix it for SDK_INT < 30, maybe it isnt a problem.

[brackeen]

Thanks for the details. I haven't been able to reproduce the CalledFromWrongThreadException issue. Just to be sure - are you using the latest glfm code from the main branch?

[maztheman]

yes, I cloned from main, copied the typing.c and copied all the files needed to compile to a separate project. The SDK version is 35.