Feature/clear date time tag priority #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/Clear-DateTime-Tag-Priority
…pigallery2 into feature/Clear-DateTime-Tag-Priority
…ature/Clear-DateTime-Tag-Priority
bpatrik
reviewed
Apr 18, 2024
| //This is the PRIORITIZED LIST of tags which Pigallery2 uses to determine the date of creation of pictures. | ||
| //The list is used for embedded picture metadata and xmp-sidecar files for both pictures and vidoes. | ||
|
|
||
| export const DateTags: [string, string, string][] = [ |
There was a problem hiding this comment.
Can you add documentation or better typing about the DateTag type here.
I would just probably declare a type timesptamp = string, typeoffset= string, etc..
There was a problem hiding this comment.
Good idea. I made a commit with something that looks a bit like that. Can be changed of course. Let me know ;)
There was a problem hiding this comment.
thank you, its way easier to understand.
|
Thank you! This is a very nice addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of metadata date handling. Since there are over 150 different date/timestamp tags, some new requirements will probably pop up over time.
In the effort of keeping MetadataLoader relatively simple, this PR adds a simple list of tags (in the notation of the exifr library) in a stand-alone file
src/backend/model/fileaccess/MetadataCreationDate.tsThe list is a prioritized list of tags that MetadataLoader is using to lookup
creationDateandcreationDateOffset. The first one found is used. If it does not contain offset, offset will be searched for in other tags under the conditions that these timestamps are close enough to the first.The new solution allows any contributer to add more tags to the list or change the priority of the tags (if there is a good reason). The priority currently used, puts standardised exif first and has photoshop shortly after and leaves various modification dates at the bottom, since modification can be done long time after creation.
As before side car metadata are loaded last, which means that sidecar data will "overwrite" embedded data in Pigallery2's metadata (not in the real photos).
flatxmp.xmp, which has now been fixed.Also added some more test data