Fixes for extension config loading (issue #847) #884
Conversation
* Actually add/remove extensions from `Config.Extensions.extensions` * Fix the file path where `ExtensionConfigTemplateLoader` looks for extensions * Prevent the first `loadSync()` call from creating a `config.json` file Works around bpatrik/typeconfig#27
| @@ -79,6 +80,14 @@ export class ExtensionManager implements IObjectManager { | |||
| ); | |||
| extList.sort(); | |||
|
|
|||
| // delete not existing extensions | |||
There was a problem hiding this comment.
i wanted to avoid this. (i.e.: I removed this laoding here on porpuse.)
I would like to have a single place that is responsible loading extension config (even if they do not exists, then its an empty config).
That is why I moved all code to the extension config loader.
There was a problem hiding this comment.
I'll take a closer look at the extension config loader. I didn't see anywhere else that Config.Extensions.extensions.push(new ServerExtensionsEntryConfig(ep))); happened, so the extension configs never actually got loaded into Config.
|
I will reject this as fixes for the same issue should be already part of the master |
|
I will reject it as I think the issue that this PR try to solve is already fixed. |
Config.Extensions.extensionsExtensionConfigTemplateLoaderlooks for extensionsloadSync()call from creating aconfig.jsonfileWorks around part of the issues caused by Loading a partial config into an array doesn't populate default values typeconfig#27
This seems to fix the problems of generating a fresh config with extension settings, saving extension config changes to the file, and loading extension settings from a config file that already includes them.
As noted in #847, this isn't a complete fix. There's still the problem of adding an extension to an existing install. I don't think that can be fixed in pigallery2. I think that needs to be fixed in typeconfig.