New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vector::emplace_back()なのに一時オブジェクトを生成している #22

Open

ai2playgame opened this issue Jun 7, 2020 · 0 comments

ai2playgame commented Jun 7, 2020

directx12_samples/Chapter10/PMDActor.cpp

Lines 135 to 137 in 6947b40

    
           _motiondata[f.boneName].emplace_back(KeyFrame(f.frameNo, XMLoadFloat4(&f.quaternion), 
        
           	XMFLOAT2((float)f.bezier[3]/127.0f,(float)f.bezier[7]/127.0f), 
        
           	XMFLOAT2((float)f.bezier[11] / 127.0f, (float)f.bezier[15] / 127.0f)));

emplace_back()でvectorにオブジェクトを追加しているのに一時オブジェクトを生成しているのは冗長。（書籍中の該当コードはp378）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment