Fix lots of clang-tidy issues in fv_ops #1316
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: clang-tidy-review | |
| on: | |
| pull_request: | |
| paths: | |
| - '**.cxx' | |
| - '**.hxx' | |
| branches-ignore: | |
| # Release candidate branches tend to have big PRs which causes all sorts of problems | |
| - 'v*rc' | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: true | |
| jobs: | |
| review: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| submodules: true | |
| - name: Run clang-tidy | |
| uses: ZedThree/[email protected] | |
| id: review | |
| with: | |
| build_dir: build | |
| apt_packages: "libfftw3-dev,libnetcdf-c++4-dev,libopenmpi-dev,petsc-dev,slepc-dev,liblapack-dev,libparpack2-dev,libsundials-dev,uuid-dev" | |
| config_file: ".clang-tidy" | |
| # Googletest triggers a _lot_ of clang-tidy warnings, so ignore all | |
| # the unit tests until they're fixed or ignored upstream | |
| exclude: "tests/unit/*cxx" | |
| cmake_command: | | |
| pip install --break-system-packages cmake && \ | |
| cmake --version && \ | |
| git config --global --add safe.directory "$GITHUB_WORKSPACE" && \ | |
| cmake . -B build -DBUILD_SHARED_LIBS=ON \ | |
| -DBOUT_USE_PETSC=ON \ | |
| -DBOUT_USE_SLEPC=ON \ | |
| -DBOUT_USE_SUNDIALS=ON \ | |
| -DBOUT_BUILD_EXAMPLES=ON \ | |
| -DBOUT_BUILD_DOCS=OFF \ | |
| -DBOUT_ENABLE_PYTHON=OFF \ | |
| -DCMAKE_EXPORT_COMPILE_COMMANDS=On \ | |
| -DBOUT_UPDATE_GIT_SUBMODULE=OFF | |
| - name: Upload clang-tidy fixes | |
| uses: ZedThree/clang-tidy-review/[email protected] |