-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide any comment with just "+1" or ":thumbsup:" [$50] #7
Comments
@rappo Would like to work on this. Suggestions:-
A settings tab on the popup with a checkbox to toggle such comments. Enabled (hide +1 comments) by default. The README says auto-hide is supported already? which seems misleading.
Summary of count of hidden comments could be displayed on the settings tab/end of issues page.
A bunch of heuristics could be added to hide such comments. But don't think it's worth it, may lead to misnomers. We should settle for
If we settle only for |
@vegetableman Great! I'd love to see this added :)
In Chrome, the standard seems to be to have "Options" if you right click on the icon. This usually takes you to something like chrome-extension://extension/settings/settings.html. We should follow this convention. I'm not sure what the convention is for Firefox, but we should figure that out as Mozilla is relatively strict with their extension approval.
Correct, this is wrong. We need to update it, just haven't yet.
My suggestion is to add an event to the Issue timeline immediately after the first post. Here's a rough mockup:
Agreed. Let's only hide comments that contain just +1. I think there are three ways that +1 could appear. Plaintext, wrapped with : for the emoji, or "thumbsup" wrapped with : for the same emoji. Here's a good test issue since there are a bunch of +1s on it: angular/angular.js#1699 |
Agreed. Thanks for sharing the angular link. Working on it. |
Added support for chrome. checkout #52 |
Added firefox support and refactored the code. Could be merged now. |
👍 Thanks for the contribution! |
Open to discussion about how to hide the comments without completely losing them
Did you help close this issue? Go claim the $50 bounty on Bountysource.
The text was updated successfully, but these errors were encountered: